Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JSON Schema in determineScalarType #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support JSON Schema in determineScalarType #2

wants to merge 1 commit into from

Conversation

P0lip
Copy link

@P0lip P0lip commented Jan 21, 2020

@P0lip P0lip added the enhancement New feature or request label Jan 21, 2020
@P0lip P0lip self-assigned this Jan 21, 2020
@P0lip
Copy link
Author

P0lip commented Jan 21, 2020

@nulltoken what do you think?
Using JSON Schema is more strict, therefore I expect the change might be painful.

@nulltoken
Copy link

@nulltoken what do you think?

@P0lip I like it!

Using JSON Schema is more strict, therefore I expect the change might be painful.

Maybe prep up a migration strategy with an optional switch for next major version set to 'Core' by default and warning users that they should test their own use cases with the 'JsonSchema' value (and report weird bugs). And then set 'JsonSchema' as the default for vn+1?

Few additional thoughts:

  • Do we also support octal and hex representations of an int?
  • I believe the Spectral doco should eventually point out to some sections of the YAML specs in order to make it clear what's supported/expected and what's not.

nulltoken
nulltoken reviewed Jan 21, 2020
View reviewed changes
src/scalarInference.ts
case DetermineScalarSchema.Core:
return determineScalarTypeForCoreSchema(node);
case DetermineScalarSchema.Json:
return determineScalarTypeForJsonSchema(node);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw on default to protect from future mistakes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulltoken nulltoken nulltoken left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Falsely Identifying Strings as Octals
2 participants
@P0lip @nulltoken