Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(asyncapi): make asyncapi-payload-* rules support asyncapi schemaFormats #1120

Closed
wants to merge 4 commits into from
Closed

[WIP] feat(asyncapi): make asyncapi-payload-* rules support asyncapi schemaFormats #1120

wants to merge 4 commits into from

Conversation

nulltoken
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Follow up work on #974 AsyncAPI PR.

  • Fixes a technical debt I introduced
  • Paves the way to make it easier to validate payloads against other schemas (Avro, OAS3, ...)

@nulltoken nulltoken self-assigned this Apr 24, 2020
@nulltoken nulltoken changed the title Ntk/asyncapi payload schema feat(asyncapi): make asyncapi-payload support asyncapi schemaFormats Apr 24, 2020
@nulltoken
Copy link
Contributor Author

/cc @derberg @fmvilas

@nulltoken nulltoken requested review from P0lip and philsturgeon April 24, 2020 09:48
@nulltoken nulltoken marked this pull request as draft April 24, 2020 12:12
@nulltoken nulltoken changed the title feat(asyncapi): make asyncapi-payload support asyncapi schemaFormats [WIP] feat(asyncapi): make asyncapi-payload support asyncapi schemaFormats Apr 24, 2020
@nulltoken nulltoken changed the title [WIP] feat(asyncapi): make asyncapi-payload support asyncapi schemaFormats [WIP] feat(asyncapi): make asyncapi-payload-* rules support asyncapi schemaFormats Apr 24, 2020
philsturgeon
philsturgeon previously approved these changes Apr 24, 2020
fmvilas
fmvilas previously approved these changes Apr 27, 2020
Copy link

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

deprecated: 14,
};
describe('AsyncApi2 schema', () => {
const validSchemaFormats = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nulltoken Use exported values from the func

@P0lip
Copy link
Contributor

P0lip commented Oct 5, 2021

Going to close this one.
If you ever happen to find some time to get this one over the finish line, do feel free to reopen it.
If you still remember, you can also tell me what's left here and I may get it done in my spare time.

@P0lip P0lip closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants