Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare assets generation for future changes #1013

Merged
merged 5 commits into from
Mar 19, 2020
Merged

chore: prepare assets generation for future changes #1013

merged 5 commits into from
Mar 19, 2020

Conversation

nulltoken
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Parts of this PR are extracted from #974 and could be reviewed/merged independently.

Rationale:

  • Migrating generate-assets made it easier to tinker with while fighting with asyncapi serialization. I believe keeping as is slightly enhance its maintainability.
  • Also resulting from this battle, some tests have been added to start describing expectations with regards to the serialization of those assets.

@nulltoken nulltoken requested a review from P0lip March 13, 2020 19:02
@nulltoken nulltoken self-assigned this Mar 13, 2020
@nulltoken
Copy link
Contributor Author

@P0lip Kind bump?

@P0lip P0lip merged commit 74b3907 into stoplightio:develop Mar 19, 2020
@nulltoken nulltoken deleted the ntk/assets branch March 19, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants