Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no refreshurl for client credentials flow in auth2 #66

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

sekharbr
Copy link
Contributor

@sekharbr sekharbr commented Jun 19, 2024

client credentials flow, there are no refresh url. and https://www.rfc-editor.org/rfc/rfc6749#section-4.4.3 states that "a refresh token SHOULD NOT be included" in client credentials flow of auth2 and so there would be no point of a refresh url truth check. This change will check for refresh url in all auth2 flow except client credentials flow

Motivation and Context

#InsertIssueNumberHere

Description

How Has This Been Tested?

Screenshot(s)/recordings(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

client credentials flow, there are no refresh url. and https://www.rfc-editor.org/rfc/rfc6749#section-4.4.3
states that "a refresh token SHOULD NOT be included" in client credentials flow of auth2 and so there would be no point of a refresh url truth check.
This change will check for refresh url in all auth2 flow except client credentials flow
@sekharbr
Copy link
Contributor Author

sekharbr commented Jul 4, 2024

Can someone review and approve the MR

@mnaumanali94 mnaumanali94 self-requested a review September 13, 2024 19:17
@mnaumanali94 mnaumanali94 enabled auto-merge (squash) September 13, 2024 19:17
@mnaumanali94 mnaumanali94 merged commit 26819e8 into stoplightio:main Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants