fix: resolveRef

stoplightio · Feb 27, 2020 · 13ffc48 · 13ffc48
1 parent e59a5f2
commit 13ffc48
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/components/JsonSchemaViewer.tsx b/src/components/JsonSchemaViewer.tsx
@@ -76,11 +76,17 @@ export class JsonSchemaViewerComponent extends React.PureComponent<IJsonSchemaVi
 
   @action
   public componentDidUpdate(prevProps: Readonly<IJsonSchemaViewer>) {
-    if (this.treeStore.defaultExpandedDepth !== this.expandedDepth) {
+    if (prevProps.resolveRef !== this.props.resolveRef) {
+      this.tree.resolveRef = this.props.resolveRef;
+    }
+
+    if (
+      this.treeStore.defaultExpandedDepth !== this.expandedDepth ||
+      prevProps.schema !== this.props.schema ||
+      prevProps.mergeAllOf !== this.props.mergeAllOf
+    ) {
       this.treeStore.defaultExpandedDepth = this.expandedDepth;
       this.tree.expandedDepth = this.expandedDepth;
-      this.renderSchema();
-    } else if (prevProps.schema !== this.props.schema || prevProps.mergeAllOf !== this.props.mergeAllOf) {
       this.tree.mergeAllOf = this.mergeAllOf;
       this.tree.schema = this.props.schema;
       this.renderSchema();

diff --git a/src/tree/tree.ts b/src/tree/tree.ts
@@ -21,7 +21,7 @@ export { TreeState as SchemaTreeState };
 export class SchemaTree extends Tree {
   public expandedDepth: number;
   public mergeAllOf: boolean;
-  protected resolveRef: Optional<SchemaTreeRefDereferenceFn>;
+  public resolveRef: Optional<SchemaTreeRefDereferenceFn>;
 
   constructor(public schema: JSONSchema4, public state: TreeState, opts: SchemaTreeOptions) {
     super();