Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tree): account for resolveInlineRef behavior when $ref has siblings #25

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat(tree): account for resolveInlineRef behavior when $ref has siblings #25

merged 2 commits into from
Nov 15, 2023

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 15, 2023

Fixes #19

@P0lip P0lip requested a review from mallachari November 15, 2023 17:59
@P0lip P0lip self-assigned this Nov 15, 2023
@daniel-white daniel-white changed the title fix(tree): account for resolveInlineRef behavior when $ref has siblings feat(tree): account for resolveInlineRef behavior when $ref has siblings Nov 15, 2023
mallachari
mallachari approved these changes Nov 15, 2023
View reviewed changes
Copy link

@mallachari mallachari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both, the fix and maxDepth config option, look and work fine

src/__tests__/tree.spec.ts
);

const w = new SchemaTree(schema, {
maxRefDepth: 1000,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that after the fix processing this schema will work properly and won't reach max depth

@daniel-white daniel-white merged commit 628627c into master Nov 15, 2023
3 checks passed
@daniel-white daniel-white deleted the fix/tree/resolve-ref branch November 15, 2023 18:52
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@P0lip P0lip mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallachari mallachari mallachari approved these changes

Assignees

@P0lip P0lip

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RangeError: maximum stack size exceeded error (refers to #18)
3 participants
@P0lip @mallachari @daniel-white