Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oas): prevent duplicate null values in enum array [ISSUE-271] #272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Drew-Kimberly
Copy link

Motivation and Context

null is always appended to enum array for nullable enum property. This can result in an invalid JSON schema document when null is already included as part of the enum array.
#271

Description

Checks for a null value in the enum array before appending one.

How Has This Been Tested?

Updated the OAS test fixture in f77dcf8 to demonstrate issue in resultant snapshots.

Fix can be observed in 7452a4b where invalid null values are no longer present.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant