fix(oas): prevent duplicate null values in enum array [ISSUE-271] #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
null
is always appended toenum
array for nullable enum property. This can result in an invalid JSON schema document whennull
is already included as part of theenum
array.#271
Description
Checks for a
null
value in theenum
array before appending one.How Has This Been Tested?
Updated the OAS test fixture in f77dcf8 to demonstrate issue in resultant snapshots.
Fix can be observed in 7452a4b where invalid
null
values are no longer present.Types of changes
Checklist