Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop urijs #167

Merged
merged 1 commit into from
Mar 23, 2022
Merged

feat: drop urijs #167

merged 1 commit into from
Mar 23, 2022

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jan 13, 2022 •
edited
Loading

2 reasons for doing so:

  • enabling esModuleInterop in feat: dual packaging #168 without changing too much of the code
  • we just don't need that dependency at all

@P0lip P0lip changed the base branch from master to beta March 23, 2022 19:27
@P0lip P0lip marked this pull request as ready for review March 23, 2022 19:27
@P0lip P0lip requested review from lottamus and marbemac as code owners March 23, 2022 19:27
@P0lip P0lip self-assigned this Mar 23, 2022
@P0lip P0lip added the enhancement New feature or request label Mar 23, 2022
@P0lip P0lip requested a review from a team March 23, 2022 19:27
lottamus
lottamus approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@lottamus lottamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming it doesn't break anything downstream (which I assume it does not)

@P0lip
Copy link
Contributor Author

P0lip commented Mar 23, 2022

It shouldn't, yeah.

@P0lip P0lip merged commit f615551 into beta Mar 23, 2022
@P0lip P0lip deleted the feat/uri-js branch March 23, 2022 20:24
P0lip added a commit that referenced this pull request Mar 24, 2022
@P0lip
feat: drop urijs (#167)
9ebc100
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 5.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

P0lip added a commit that referenced this pull request Apr 7, 2022
@P0lip
feat: drop urijs (#167)
42ae0ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lottamus lottamus lottamus approved these changes

@marbemac marbemac Awaiting requested review from marbemac

Assignees

@P0lip P0lip

Labels
enhancement New feature or request released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P0lip @stoplight-bot @lottamus