-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Content-Type header added despite no request body defined in POST/PUT/PATCH endpoints #2739
base: main
Are you sure you want to change the base?
fix: Content-Type header added despite no request body defined in POST/PUT/PATCH endpoints #2739
Conversation
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ddc6051
to
00b8544
Compare
I would greatly appreciate it if someone could review this. Thank you! |
@nikrooz The code looks good, but if you want for these changes to be released after merging, you have to bump up versions in the proper cc. @mnaumanali94 |
24bbe18
to
74358ed
Compare
@darekplawecki Thank you for your comments. I've updated the version; please let me know if there's anything else
Update: since the fix landed in main #2750, I removed my fix commit in this PR |
74358ed
to
c99eeb6
Compare
Hi team, any chance we can review this and get it merged. Thanks! |
Signed-off-by: Nik Nasr <[email protected]>
Signed-off-by: Nik Nasr <[email protected]>
Signed-off-by: Nik Nasr <[email protected]>
1b5218a
to
3e326e7
Compare
@darekplawecki Could you please take another look at this? I would greatly appreciate it, as our upcoming release is currently blocked by this fix. |
Addressed
#2734
Changes
If no request body is defined, the Content-Type header should not be included.
Screenshot
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.md
Other Available PR Templates:
CONTRIBUTING.md