Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: callbacks #2480

Merged
merged 3 commits into from
Dec 15, 2023
Merged

feat: callbacks #2480

merged 3 commits into from
Dec 15, 2023

Conversation

mallachari
Copy link

@mallachari mallachari commented Dec 14, 2023

Addresses: https://github.com/stoplightio/platform-internal/issues/18498

Adds callbacks to HttpOperation

Screenshot 2023-12-13 at 23 29 56
Screen.Recording.2023-12-13.at.23.28.52.mov

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit df5e76b
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/657c6a55828ec6000832cd52
😎 Deploy Preview https://deploy-preview-2480--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit df5e76b
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/657c6a55f4e9710008991a40
😎 Deploy Preview https://deploy-preview-2480--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mallachari mallachari marked this pull request as ready for review December 14, 2023 08:49
@mallachari mallachari requested a review from a team as a code owner December 14, 2023 08:49
@mallachari mallachari requested review from raleigh04, a team and chohmann and removed request for a team and raleigh04 December 14, 2023 08:49
Copy link
Contributor

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me! I think we should let @ryotrellim give it a once over for design and maybe let @matthewmurphy take a look for testing purposes.

@chohmann chohmann requested a review from ryotrellim December 14, 2023 15:36
@mallachari
Copy link
Author

@ryotrellim did you have a chance to take a look at it?

Copy link
Contributor

@ryotrellim ryotrellim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@mallachari mallachari merged commit 43b8ff6 into main Dec 15, 2023
7 checks passed
@mallachari mallachari deleted the feat/callbacks branch December 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants