acmtable performance

[jeswanke]

every time the items changed, a new selected object was created:

useLayoutEffect(() => {
    const newSelected: { [uid: string]: boolean } = {}
     :             :             :
    setSelected(newSelected)
}, [items])

which caused the memo used to calculate the rows to re-run:

const { rows, addedSubRowCount } = useMemo<{ rows: IRow[]; addedSubRowCount: number }>(() => {

     :             :             :

}, selected, paged, columns, expanded, openGroups, keyFn])

because react just uses === to determine if the dependency changes and it was always a new object:

so fix is to compare the json of the object:

}, [JSON.stringify(selected), paged, columns, expanded, openGroups, keyFn])

Signed-off-by: John Swanke [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeswanke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jamestalton]

/hold

[jamestalton]

I'd like to see if we can smartly update the selected vs using JSON.stringify