Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://issues.redhat.com/browse/ACM-14244 suggestion #7250

Open
wants to merge 4 commits into
base: 2.12_stage
Choose a base branch
from
Open

https://issues.redhat.com/browse/ACM-14244 suggestion #7250

wants to merge 4 commits into from

Conversation

dockerymick
Copy link
Contributor

@dockerymick dockerymick mentioned this pull request Nov 18, 2024
Open
gparvin
gparvin reviewed Nov 20, 2024
View reviewed changes
release_notes/known_issues_governance.adoc Outdated
@@ -77,6 +77,9 @@ To resolve the issue, disable the policy and compare the differences between `ob
+
To resolve the issue, disable the policy and compare the differences between `objectDefinition` in the policy and the object on the managed cluster. If the keys are different or missing, Kubernetes might have processed the keys before applying them to the object, such as removing keys containing default or empty values.
- When you run out of memory because there are too many policy events created from continuous compliance changes, the `governance-policy-framework-addon` pod crashes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reword this so it's a little more clear the Out of Memory issue is specific to the governance policy framework addon pod as opposed to other concerns with the events?

gparvin
gparvin approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@gparvin gparvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now. You could move this sentence to the second sentence of the intro before the bullet points since this bullet point applies to both of the other two.

@openshift-ci openshift-ci bot added the lgtm label Dec 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dockerymick, gparvin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dockerymick
Update known_issues_governance.adoc
b326a99 
Updates after dev review
@openshift-ci openshift-ci bot removed the lgtm label Dec 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

New changes are detected. LGTM label has been removed.

@dockerymick
Copy link
Contributor Author

@gparvin thanks for your review and approval. I made an update based on your comment. Are you ok with us closing the old PR? https://github.com/stolostron/rhacm-docs/pull/7208/files#r1847257876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gparvin gparvin gparvin approved these changes

Assignees

@gparvin gparvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dockerymick @gparvin