Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route agent healthcheck #4054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aswinsuryan
Copy link
Contributor

Add route agent healthcheck

Copy link

openshift-ci bot commented Nov 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Nov 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aswinsuryan
Once this PR has been reviewed and has the lgtm label, please assign fxiang1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aswinsuryan aswinsuryan force-pushed the ra-healthcheck branch 2 times, most recently from 4e2547c to d7253fb Compare November 12, 2024 22:04
@aswinsuryan aswinsuryan marked this pull request as ready for review November 15, 2024 19:13
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Signed-off-by: Aswin Suryanarayanan <[email protected]>
Copy link

openshift-ci bot commented Nov 27, 2024

@aswinsuryan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 1dde0cc link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant