-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read me and documentation #3
base: main
Are you sure you want to change the base?
Conversation
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/stochastic-sisyphus/synsearch?shareId=XXXX-XXXX-XXXX-XXXX).
Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev or contact us. |
Reviewer's Guide by SourceryThis PR primarily focuses on enhancing documentation by adding comprehensive configuration documentation to the README.md file and updating the project planning document with configuration-related details. The changes provide detailed explanations of all configuration options available in the system, including data processing, model parameters, and pipeline settings. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @stochastic-sisyphus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the duplicate configuration documentation from plan.md and keeping it only in README.md to avoid maintenance issues. The plan.md file should focus on development planning and strategy.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
#### Preprocessing Configuration | ||
```yaml | ||
preprocessing: | ||
min_length: 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Please specify the units for min_length and max_length (characters, words, or tokens).
Suggested implementation:
min_length: 100 # characters
max_length: 1000 # characters
min_text_length: 100 # characters
max_text_length: 1000 # characters
For more details, open the Copilot Workspace session.
Summary by Sourcery
Documentation: