Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start alarm by subSeconds: Avoid overflow during conversion from ms to ticks. #113

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Start alarm by subSeconds: Avoid overflow during conversion from ms to ticks. #113

merged 1 commit into from
Nov 27, 2024

Commits on Nov 24, 2024

  1. Avoid overflow during conversion from ms to ticks. 

    E.g. when having predivSync=255, a value of subSeconds=2^24 (still well below UINT32_MAX and thus using the 32bit computation branch) would be multiplied by 256 and result in an overflow during computation. In fact, 2^24 ms is about 4 hours 40 minutes.
    @mrschuster
    mrschuster committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    da7be45 View commit details
    Browse the repository at this point in the history