adsGetNetIdForPLC: Solve too small buffer size for build 4026+ #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some PLCs that run TwinCAT >4026 send more bytes than expected when requesting the AMS NetID. This patch allocates more buffer size to the response to solve an error where the function would error out for no appearant reason.
|
Thanks for this, will look into merging shortly, do you think this will fix #432 ? |
|
Does this also work with no consequences for 4024? |
|
Thankyou for your fast response. I do not think that this would solve the other issue. This error originated in that the PLC sent more data than expected... Regarding the tests, I can do some tomorrow. I will add another comment to let you know about that. |
|
@chrisbeardy I confirm that this change can be used with 4024. In fact, the buffer size can be way bigger even, so that's something we can think about doing to prevent such errors |
Pull Request Test Coverage Report for Build 12134055749Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PLCs that run TwinCAT >4026 send more bytes than expected when requesting the AMS NetID. This patch allocates more buffer size to the response to solve an error where the function would error out for no appearant reason.