Adding Support for custom handlers #27
Conversation
sean-parent
commented
Oct 14, 2024
•
sean-parent
commented
- Support for custom handlers (see ReadMe.md and new unit tests).
- Some project cleanup: Removed unused features from the template.
- Added support files for VSCode.
- Some non-C++ files also got auto-linted.
- Cleaned up a warning in the CMake (still two warnings left).
In VSCode, the test explorer doesn't play well with gtest tests.
dabrahams
force-pushed
the
sean-parent/vscode-cleanup
branch
from
f8ae395 to
1ad5373
Compare
…/adobe-contract-checks into sean-parent/vscode-cleanup
…dd file associations
| - "-readability-avoid-const-params-in-decls" | ||
| - "-readability-else-after-return" | ||
| - "-readability-function-cognitive-complexity" | ||
| - "-readability-identifier-length" |
There was a problem hiding this comment.
Reasons for changes in this file are unclear. Remember that anything we're turning off to make our headers pass linting needs to be off in clients, so maybe we should be suppressing things with in-code comments.
There was a problem hiding this comment.
Agreed - I'll make a separate PR to clean these out or at least provide a rationale for anything left on.
|
|
||
| }// namespace | ||
|
|
||
| #define STRINGIZE(x) STRINGIZE2(x)// NOLINT(cppcoreguidelines-macro-usage) |
There was a problem hiding this comment.
Doc comments on these macros too please. If this is a better idiom for capturing the line number we should use it in the other tests too, right? Is it better?
There was a problem hiding this comment.
It's the same idiom you use in verbose_configuration_tests.cpp - is it better than what?
There was a problem hiding this comment.
I didn't recall having LINE_STRING, but since it's the same, we should DRY it, right?
Co-authored-by: Dave Abrahams <[email protected]>
I don't disagree - if you have some good tips about how to fix things when you see them in separate PRs with minimal friction, I'd love some suggestions. In my experience, several dependent PRs become very problematic. |
Revisit if we add other formatters
| clangFormatVersion: 12 | ||
| inplace: True | ||
| - uses: EndBug/add-and-commit@v9 | ||
| with: | ||
| author_name: Clang Robot | ||
| author_email: [email protected] | ||
| message: ':art: Committing clang-format changes' | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
| ref: ${{ github.event.pull_request.head.ref }} |
There was a problem hiding this comment.
What are these changes about?
| @@ -1,3 +1,7 @@ | |||
| { | |||
| "cmake.ctest.testExplorerIntegrationEnabled": true | |||
| "cmake.ctest.testExplorerIntegrationEnabled": false, | |||
There was a problem hiding this comment.
This kind of change should get a comment saying it's a workaround and a reference to an issue, e.g.
// WORKAROUND: https://some/github/link
