-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding pre built numberic dicterm cluster #2580
base: master
Are you sure you want to change the base?
Conversation
server/src/termdb.matrix.js
Outdated
called in mds3.init | ||
*/ | ||
export async function mayInitiateNumericDictionaryTermplots(ds) { | ||
if (!ds.cohort.numericDictTermClusterPlots) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please define type def for ds.cohort.numericDictTermClusterPlots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks just added
f419fdf
to
6f3918b
Compare
what do u think about combining the existing ds.cohort.termdb.numericDictTermCluster{} into the new property, thus gather related things in one place
|
thanks that's a good idea, just combined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. so list samples on spanning on matrix doesn't show values in second column. is that intentional or a bug?
did u commit? i don't see the two are combined |
sorry my git push failed, just pushed again, please check |
settings?: { | ||
[key: string]: any | ||
} | ||
getConfig?: (f: any) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's purpose of getConfig()?
thanks a lot this looks better. please update sjpp branch in order to test |
Description
Please test with sjpp branch: ALL_prebuilt_matrix_numericDictTermCluster
Checklist
Check each task that has been performed or verified to be not applicable.