Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queue mechanism #147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add queue mechanism #147

wants to merge 3 commits into from

Conversation

leastbad
Copy link
Contributor

@leastbad leastbad commented Jul 9, 2022

Type of PR (feature, enhancement, bug fix, etc.)

Enhancement

Description

Action Cable messaging queue based on similar functionality to what was recently added to StimulusReflex.

Allows transmission or queueing of events - both individual and batch - based on the connection status of the AC subscription.

Why should this be added

Shrinks codebase size and complexity without reimplementing a falloff mechanism. Instead of retries, why not wait until Action Cable is ready for us to send?

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@leastbad leastbad added enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 9, 2022
@leastbad
Copy link
Contributor Author

leastbad commented Jul 9, 2022

We haven't discussed this one, so I won't feel bad if you don't pick it up. I just figured that I'd strike while the memory was hot.

Also: please delete the connectivity branch. It was an early, aborted attempt that accidentally branched from the previous PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant