Multiple cause areas #622
Merged
Multiple cause areas #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix fake data
# Conflicts: # prisma/schema.prisma # src/routes/swish.ts
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| HAVING SUM(CauseAreasOrgSum) = 100; | ||
| `; | ||
|
|
||
| const [res] = await DAO.query(query, [input.donorId, input.taxUnitId, input.taxUnitId]); |
There was a problem hiding this comment.
Detected a mysql2 SQL statement that comes from a function argument. This could lead to SQL injection if the variable is user-controlled and is not properly sanitized. In order to prevent SQL injection, it is recommended to use parameterized queries or prepared statements.
View Dataflow Graph
flowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>src/custom_modules/DAO_modules/distributions.ts</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0("<b>[Line: 329]</b> input")
end
%% Intermediate
subgraph Traces0[Traces]
direction TB
v2("<b>[Line: 303]</b> query")
end
%% Sink
subgraph Sink
direction LR
v1("<b>[Line: 371]</b> query")
end
end
%% Class Assignment
Source:::invis
Sink:::invis
Traces0:::invis
File0:::invis
%% Connections
Source --> Traces0
Traces0 --> Sink
%% Clickable
click v0 href "https://github.com/stiftelsen-effekt/effekt-backend/blob/22e78626f18755ede87e2792191fcbac35bcbc5e/src/custom_modules/DAO_modules/distributions.ts#L329" "View in source" _blank
click v1 href "https://github.com/stiftelsen-effekt/effekt-backend/blob/22e78626f18755ede87e2792191fcbac35bcbc5e/src/custom_modules/DAO_modules/distributions.ts#L371" "View in source" _blank
click v2 href "https://github.com/stiftelsen-effekt/effekt-backend/blob/22e78626f18755ede87e2792191fcbac35bcbc5e/src/custom_modules/DAO_modules/distributions.ts#L303" "View in source" _blank
|
Semgrep found 1
Detected a View Dataflow Graphflowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>src/custom_modules/DAO_modules/distributions.ts</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0("<b>[Line: 53]</b> sort")
end
%% Intermediate
subgraph Traces0[Traces]
direction TB
v2("<b>[Line: 33]</b> queryString")
end
%% Sink
subgraph Sink
direction LR
v1("<b>[Line: 57]</b> queryString")
end
end
%% Class Assignment
Source:::invis
Sink:::invis
Traces0:::invis
File0:::invis
%% Connections
Source --> Traces0
Traces0 --> Sink
%% Clickable
click v0 href "https://github.com/stiftelsen-effekt/effekt-backend/blob/22e78626f18755ede87e2792191fcbac35bcbc5e/src/custom_modules/DAO_modules/distributions.ts#L53" "View in source" _blank
click v1 href "https://github.com/stiftelsen-effekt/effekt-backend/blob/22e78626f18755ede87e2792191fcbac35bcbc5e/src/custom_modules/DAO_modules/distributions.ts#L57" "View in source" _blank
click v2 href "https://github.com/stiftelsen-effekt/effekt-backend/blob/22e78626f18755ede87e2792191fcbac35bcbc5e/src/custom_modules/DAO_modules/distributions.ts#L33" "View in source" _blank
|
…-getByDonorId Updates getByDonorId to new schema and adds simple test
…-getAllByDonor Updates getAllByDonor to new schema and adds simple tests
…-getAll Updates getAll function to new structure and adds simple tests
…esponse Backwards compatible response
# Conflicts: # src/custom_modules/DAO_modules/distributions.ts # src/routes/avtalegiro.ts # src/routes/donations.ts # src/routes/donors.ts
…atible-api Backwards compatible api
|
Amazing! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #611