Fix restart to continue steps #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #353
I had also looked at changing
dyn.nstepsitself, but adds complications such as with different implementations ofdyn.get_time(), some, but not all, of which depend onnsteps.While it's not straightforward to test a real interrupted simulation, I've updated the restart step numbers so that the "continued"
stepsis the same as the previous "extended"steps.In most cases, this means the new final
stepsis the sum of the original twosteps, but note in the case oftest_auto_restart_restart_stem, this is not the case, due to the frequency of the restart file being written.