Add preprocessing training data #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElliottKasoar
force-pushed
the
add-preprocess
branch
3 times, most recently
from
903ea88 to
7351264
Compare
oerc0122
reviewed
Nov 4, 2024
ElliottKasoar
force-pushed
the
add-preprocess
branch
from
4bddd0c to
ae00eec
Compare
ElliottKasoar
force-pushed
the
add-preprocess
branch
from
ae00eec to
019facc
Compare
ElliottKasoar
force-pushed
the
add-preprocess
branch
from
019facc to
83a1578
Compare
oerc0122
previously approved these changes
Nov 8, 2024
ElliottKasoar
force-pushed
the
add-preprocess
branch
from
83a1578 to
4c12e2e
Compare
|
(Rebased and updated use of |
alinelena
reviewed
Nov 14, 2024
alinelena
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37
This probably should should probably be moved to
trainingafter #341 is merged.This also currently relies on us passing each config option. I'm hoping we should be able to update this (see MACE PR) to allow the config to be passed straight through, as we do for training.