Version 2.0.0 #20
Merged
Version 2.0.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a Makefile for easy command execution
This will let us leverage the PHPCompatibility ruleset, cutting out a lot of CI overhead.
I love being fancy as much as the next dev, but this package defines constants; running PHP_CodeSniffer with the PHPCompatibility ruleset should be sufficient.
Switch from PHP-CS-Fixer to PHP_CodeSniffer w/ PHPCompatibility
…ent, global namespace behavior This is probably overkill, but if someone is using version 1.x of this library in a number of places and doesn't want to deal with upgrading all references at once, this double-defines the constants.
Namespace the constants by default
stevegrunwell
force-pushed
the
release/v2.0.0
branch
from
9121a43
to
5d3ebc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeConstantsnamespace (Namespace the constants by default #18)