feat: Adds syntax highlighting in the telescope picker #386
Conversation
lua/telescope/_extensions/aerial.lua
Outdated
| local ts_parsers = require("nvim-treesitter.parsers") | ||
| local ts_query = require("nvim-treesitter.query") |
There was a problem hiding this comment.
This introduces a hard dependency on nvim-treesitter. Could this be reworked to only use the built-in vim.treesitter APIs?
There was a problem hiding this comment.
yes, works as well w/o it, done
lua/telescope/_extensions/aerial.lua
Outdated
| for _, value in ipairs(buf_highlights) do | ||
| local start_row, start_col, end_row, end_col = unpack(value.range) | ||
|
|
||
| if start_row == row then | ||
| local type = value.capture:gsub("%..*", "") -- strip subtypes after dot | ||
| table.insert(highlights, { { start_col + offset, end_col + offset }, type }) | ||
| end | ||
| end |
There was a problem hiding this comment.
This looks like an n-squared algorithm; I would expect it to lag on large files. Could we instead store the buf_highlights in a structure that is indexed by the start_row?
There was a problem hiding this comment.
done, updated to index based way
lua/telescope/_extensions/aerial.lua
Outdated
| only_lines = false, | ||
| show_lines = true, |
There was a problem hiding this comment.
This introduces the possibility for a nonsensical configuration (only_lines = true and show_lines = false).
Could we instead have one configuration option show_columns that can be "symbols", "lines", or "both"? And then add a shim so the old show_lines option continues to work.
There was a problem hiding this comment.
Updated to show_columns way
|
@stevearc all updated, please review |
|
LGTM, thanks for the PR! |
the highlighting for the symbol type and the symbol name were lost with that change.
the highlighting for the symbol type and the symbol name were lost with that change.
* fix telescope highlights regression from #386 the highlighting for the symbol type and the symbol name were lost with that change. * fix: telescope highlighting accounts for multibyte characters * telescope: allow to configure column widths --------- Co-authored-by: Steven Arcangeli <[email protected]>
Adds syntax highlighting in the telescope picker. Issue #384
only_linespicker config to show only code w/o symbols.Some results:
with
only_lines=trueOther notes:
only_lines- tried to name it in existing naming syntax, no any preferences, up to you