[rtlsdr] fixes for inet/inet6 and serial number parsing; bias tee fixes! #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarn
commented
Jun 25, 2020
•
erikarn
commented
- Correctly use the getaddrinfo populated response array; this stopped working on freebsd-13 this week for some odd reason which led me to correct how it's used;
- Do the serial number look-up /first/ in case the serial numbers are low (eg 00000001 , 00000002, etc) - the full and partial lookups will do the right thing if done early;
- add new method to leave the bias tee on after rtlsdr_close();
- close the bias tee gpio on rtlsdr_close() except if the above method is called;
- rtl_biast leaves the bias tee on!
erikarn
changed the title
|
This also addresses your concerns in #47 |
gvanem
reviewed
Sep 7, 2020
added 4 commits
November 30, 2020 12:09
This fixes issues seen on FreeBSD-13 as of today (23-Jun-2020.) It was returning errors during bind and not binding the right address or port. * clear hints before use * get rid of local - it's not used now, and it was only using the first entry * don't use local and hard-coded size; instead use the current ai pointer address and addrlen * Add missing \n Tested: * FreeBSD-13, 23-Jun-2020
If it's done first then numeric serial numbers that also match device ids will, well, match. This way it'll correctly find an exact match serial number and a partial serial number match before it tries a straight numeric device index lookup.
…ring close * Close the biast by default * Track the last used GPIO pin for the biast so we know which pin to close! * Add a new method which tells librtlsdr to leave it on
|
hI! ping! I've just updated the pull request against the august 2020 top of tree. Would you mind taking another look at it? thanks! -adrian |
|
hi! I'm just poking about this again! I'd love to see this land to fix compiling/running on freebsd and windows as well! Thanks! happy holidays! |
|
ping! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.