Separate functions for setting lna, mixer and vga gains (for r82xx tuner) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2016 12:29
…nd vga for r82xx as well as setting those gains individually. working well so far. Only works for r82xx tuner but doesn't break anything for others (only tried with rt820 and e4000 tuners). Shouldn't break any existing code that uses the library.
…g nearly identical code and added some comments
|
This seems useful, although would be good to confirm that this works as expected on R820T chipsets :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using an rtl-sdr with r820t tuner using rtl_power_fftw for radio astronomy. I wanted control of the lna gain for the tuner as well as mixer and vga so I made some changes to librtlsdr as well as to rtl_power_fftw to break out that functionality.
In librtlsdr I added functions for setting lna, mixer and vga gains as well as getting available gains for each. I added an enum with the gain types "lna", "mixer", "vga" and "total" (where total is the current default) to aid in re-using existing code without breaking current compatibility with code that may be using librtlsdr.
I'm fairly certain that these changes do not break any existing code that uses the library and doesn't seem to cause problems for other tuners which don't support it (I've only tried with an e4000 tuner for checking this).