-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: OS Updates and Alerts #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will not quite work as updating a single pkg may result in other pkges updated.
Also when you update all pkgs in some cases it will still show some pkgs as they're not updateable at that point.
I suggest simply fetching the stats again after updating. i think that's the easiest solution.
Thank you for the feedback! That was a good catch. I'll implement the suggested approach of fetching the stats again after updating. It makes sense to ensure we're working with the latest information. I'll update the PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #2019
fixes #2034