Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: OS Updates and Alerts #2037

Merged
merged 5 commits into from
Sep 5, 2024
Merged

FIX: OS Updates and Alerts #2037

merged 5 commits into from
Sep 5, 2024

Conversation

mabasian
Copy link
Contributor

@mabasian mabasian commented Sep 4, 2024

fixes #2019
fixes #2034

@mabasian mabasian marked this pull request as draft September 4, 2024 12:20
@mabasian mabasian marked this pull request as ready for review September 4, 2024 13:14
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will not quite work as updating a single pkg may result in other pkges updated.
Also when you update all pkgs in some cases it will still show some pkgs as they're not updateable at that point.

I suggest simply fetching the stats again after updating. i think that's the easiest solution.

@mabasian
Copy link
Contributor Author

mabasian commented Sep 5, 2024

That will not quite work as updating a single pkg may result in other pkges updated. Also when you update all pkgs in some cases it will still show some pkgs as they're not updateable at that point.

I suggest simply fetching the stats again after updating. i think that's the easiest solution.

Thank you for the feedback! That was a good catch. I'll implement the suggested approach of fetching the stats again after updating. It makes sense to ensure we're working with the latest information. I'll update the PR accordingly.

Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NeoPlays NeoPlays merged commit 4e272ca into stereum-dev:main Sep 5, 2024
4 checks passed
@mabasian mabasian deleted the fixIssue branch September 6, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OS Updates list does not refresh [Bug]: OS Updates and Alerts
2 participants