fix: Unbreak a use case for #1110 / fix for #1121 #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
changed the title
"Function" is builtin, but anything prefixed or suffixed for whatever reason shouldn't be handled the same way. So check if the final result is in builtin list, not the original unmodified name
stephenh
approved these changes
Oct 15, 2024
| const tsFullName = tsPrefix + maybeSnakeToCamel(messageName(message), options); | ||
| const tsFullNameWithAffixes = `${options.typePrefix}${tsFullName}${options.typeSuffix}`; | ||
| const tsFullName = tsPrefix + maybeSnakeToCamel(message.name, options); | ||
| const tsFullNameWithAffixes = messageName(`${options.typePrefix}${tsFullName}${options.typeSuffix}`); |
There was a problem hiding this comment.
Nice! Great fix to just move where we check the builtInNames
|
🙏 can i get another label :P |
|
Of course! Added. |
stephenh
pushed a commit
that referenced
this pull request
Oct 15, 2024
|
🎉 This issue has been resolved in version 2.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Function" is builtin, but anything prefixed or suffixed for whatever reason shouldn't be handled the same way. So check if the final result is in builtin list, not the original unmodified name
I have concerns about maybeSnakeToCamel being called earlier now, but i can't find any tests for options.snakeToCamel.includes("keys") so i'm not sure if i broke anything
But all tests pass