-
Notifications
You must be signed in to change notification settings - Fork 349
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Don't fail on Function message names (#1119)
I tried other resolved words from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects#fundamental_objects and nothing seems to break. Fixes #1110
- Loading branch information
Showing
5 changed files
with
471 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
useExactTypes=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { UserRule } from "./test-1110"; | ||
|
||
describe("test-1110", () => { | ||
it("Able to create a partial user rule with reserved word messages", () => { | ||
const simple: UserRule = UserRule.fromPartial({ UUID: "foo" }); | ||
expect(simple).toBeTruthy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
syntax = "proto3"; | ||
|
||
message UserRule { | ||
// just some fake rule for testing | ||
string UUID = 1 [json_name = "uuid"]; | ||
} | ||
|
||
message Object { | ||
string namespace = 1; | ||
string name = 2; | ||
} | ||
|
||
message Boolean { | ||
string namespace = 1; | ||
string name = 2; | ||
} | ||
|
||
message Symbol { | ||
string namespace = 1; | ||
string name = 2; | ||
} | ||
|
||
message Function { | ||
string namespace = 1; | ||
string name = 2; | ||
} | ||
|
||
service APIService { | ||
} |
Oops, something went wrong.