feat: enum decoding (#910)

* feat(ts-proto-#859): added encode-only options to toJSON methods * feat(ts-proto-#859): fixed error in implementation * feat(ts-proto#859): inverted fromJSON and toJSON methods to avoid changing all tests * feat(ts-proto#859): ran yarn format * feat(ts-proto-#859): updated docs and renamed methods to toOnly and fromOnly * feat: removed toJson/fromJSON enums when not used * feat(#909): ran format --------- Co-authored-by: Francesco Battista <[email protected]>
stephenh · Sep 3, 2023 · 9e0a0b5 · 9e0a0b5
1 parent 6c37f87
commit 9e0a0b5
Show file tree

Hide file tree

Showing 5 changed files with 53 additions and 2 deletions.
diff --git a/integration/fromJson-enums/from-json.bin b/integration/fromJson-enums/from-json.bin
diff --git a/integration/fromJson-enums/from-json.proto b/integration/fromJson-enums/from-json.proto
@@ -0,0 +1,9 @@
+message Test {
+  enum TestType {
+    TEST_TYPE_UNSPECIFIED = 0;
+    TEST_TYPE_EVENT = 1;
+    TEST_TYPE_METRIC = 2;
+    TEST_TYPE_DERIVED = 3;
+  }
+
+}
diff --git a/integration/fromJson-enums/from-json.ts b/integration/fromJson-enums/from-json.ts
@@ -0,0 +1,37 @@
+/* eslint-disable */
+
+export const protobufPackage = "";
+
+export interface Test {
+}
+
+export enum Test_TestType {
+  TEST_TYPE_UNSPECIFIED = 0,
+  TEST_TYPE_EVENT = 1,
+  TEST_TYPE_METRIC = 2,
+  TEST_TYPE_DERIVED = 3,
+  UNRECOGNIZED = -1,
+}
+
+export function test_TestTypeToJSON(object: Test_TestType): string {
+  switch (object) {
+    case Test_TestType.TEST_TYPE_UNSPECIFIED:
+      return "TEST_TYPE_UNSPECIFIED";
+    case Test_TestType.TEST_TYPE_EVENT:
+      return "TEST_TYPE_EVENT";
+    case Test_TestType.TEST_TYPE_METRIC:
+      return "TEST_TYPE_METRIC";
+    case Test_TestType.TEST_TYPE_DERIVED:
+      return "TEST_TYPE_DERIVED";
+    case Test_TestType.UNRECOGNIZED:
+    default:
+      return "UNRECOGNIZED";
+  }
+}
+
+export const Test = {
+  toJSON(_: Test): unknown {
+    const obj: any = {};
+    return obj;
+  },
+};
diff --git a/integration/fromJson-enums/parameters.txt b/integration/fromJson-enums/parameters.txt
@@ -0,0 +1 @@
+outputEncodeMethods=false,outputPartialMethods=false,outputJsonMethods=to-only,nestJs=false
diff --git a/src/enums.ts b/src/enums.ts
@@ -52,11 +52,15 @@ export function generateEnum(
     chunks.push(code`}`);
   }
 
-  if (options.outputJsonMethods || (options.stringEnums && options.outputEncodeMethods)) {
+  if (
+    options.outputJsonMethods === true ||
+    options.outputJsonMethods === "from-only" ||
+    (options.stringEnums && options.outputEncodeMethods)
+  ) {
     chunks.push(code`\n`);
     chunks.push(generateEnumFromJson(ctx, fullName, enumDesc));
   }
-  if (options.outputJsonMethods) {
+  if (options.outputJsonMethods === true || options.outputJsonMethods === "to-only") {
     chunks.push(code`\n`);
     chunks.push(generateEnumToJson(ctx, fullName, enumDesc));
   }