Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves the javascript out of the block output. #619

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kadencewp
Copy link
Contributor

🎫 #[Jira Ticket]
This is a fix for issues with how javascript can be loaded on a page delayed.
This also fixes an issue where certain hosts will strip any javascript out of a post or page content.

...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@mark-c-woodard
Copy link
Contributor

Looks good. Found one issue with formatting for one or two decimal point progress numbers. Made a commit to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants