Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: PHP doc types #21

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Bugfix: PHP doc types #21

merged 2 commits into from
Jun 6, 2024

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Jun 6, 2024

Main Changes

  • PHPStan complaining about passing an integer into where() values.
  • Removes unused variable $type in Where clause

@defunctl defunctl added the bug Something isn't working label Jun 6, 2024
@defunctl defunctl added this to the 1.1.1 milestone Jun 6, 2024
@defunctl defunctl requested a review from borkweb June 6, 2024 19:45
@defunctl defunctl self-assigned this Jun 6, 2024
@defunctl defunctl merged commit cbaed00 into main Jun 6, 2024
2 checks passed
@defunctl defunctl deleted the bugfix/php-types branch June 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkweb borkweb borkweb approved these changes

Assignees

@defunctl defunctl

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@defunctl @borkweb