Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trim( null ) #15

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Don't trim( null ) #15

merged 6 commits into from
Oct 23, 2023

Conversation

Camwyn
Copy link
Contributor

@Camwyn Camwyn commented Oct 23, 2023

Passing null to trim() is deprecated since PHP 8.1

Ticket: https://stellarwp.atlassian.net/browse/BTRIA-2080

@Camwyn Camwyn requested a review from borkweb October 23, 2023 15:39
@Camwyn Camwyn self-assigned this Oct 23, 2023
src/DB/QueryBuilder/Clauses/Select.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Clauses/Join.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Clauses/From.php Outdated Show resolved Hide resolved
@Camwyn Camwyn requested a review from borkweb October 23, 2023 17:52
@Camwyn Camwyn added the enhancement New feature or request label Oct 23, 2023
src/DB/QueryBuilder/Clauses/From.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Clauses/Join.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Clauses/Select.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Concerns/FromClause.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Concerns/JoinClause.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Concerns/JoinClause.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/Concerns/JoinClause.php Outdated Show resolved Hide resolved
src/DB/QueryBuilder/JoinQueryBuilder.php Outdated Show resolved Hide resolved
src/DB/DB.php Outdated Show resolved Hide resolved
@borkweb borkweb merged commit e299e35 into main Oct 23, 2023
2 checks passed
@borkweb borkweb deleted the fix/php-8.1-deprecation branch October 23, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants