-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and fix sizing for hubble data dicts #1094
Conversation
|
Preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we drop the Primary Keys from all of the Table Metadata? Most of these tables do not have primary keys, and I'd like consistency across all tables.
Also the history_assets
table is missing Natural Keys if you don't mind filling those in
Updated in f1268f4 and 4f19205 There were actually a lot of issues with the table metadata lol
|
Preview is available here: |
1 similar comment
Preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking the merge, looks good
|
||
| Property | Configuration | | ||
| --- | --- | | ||
| Natural Key(s) | history_operation_id, order, ledger_closed_at | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nitty: i think history_operation_id
and order
are unique without ledger_closed_at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's right
Preview is available here: |
Updates and table formatting and organization changes for Hubble data dicts