Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix sizing for hubble data dicts #1094

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Nov 22, 2024

Updates and table formatting and organization changes for Hubble data dicts

@chowbao
Copy link
Contributor Author

chowbao commented Nov 22, 2024

  • Data dicts content has been copied over
  • Table css simplified and formats the table a little better and will auto adjust column sizing based on column content

@stellar-jenkins
Copy link

Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we drop the Primary Keys from all of the Table Metadata? Most of these tables do not have primary keys, and I'd like consistency across all tables.

Also the history_assets table is missing Natural Keys if you don't mind filling those in

@chowbao
Copy link
Contributor Author

chowbao commented Nov 22, 2024

nit: can we drop the Primary Keys from all of the Table Metadata? Most of these tables do not have primary keys, and I'd like consistency across all tables.

Also the history_assets table is missing Natural Keys if you don't mind filling those in

Updated in f1268f4 and 4f19205

There were actually a lot of issues with the table metadata lol

  • Reduced the natural keys to actual unique identifier of data by using closed_at
  • Fixed the dbt docs link to use the public dbt docs instead of the private one
  • Fixed incorrect partition fields
  • Fixed cluster ordering

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking the merge, looks good


| Property | Configuration |
| --- | --- |
| Natural Key(s) | history_operation_id, order, ledger_closed_at |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nitty: i think history_operation_id and order are unique without ledger_closed_at

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's right

@stellar-jenkins
Copy link

@chowbao chowbao merged commit 16bff09 into main Nov 22, 2024
2 checks passed
@chowbao chowbao deleted the hubble-data-dict-table-sizing-and-updates branch November 22, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants