[SDP-1415] scroll to top when displaying a notification banner #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stellar-disbursement-platform-frontend-preview is available here: |
quietbits
reviewed
Nov 21, 2024
Comment on lines
+1
to
+18
| export type toDirection = "top" | "bottom"; | ||
|
|
||
| export const scrollTo = (direction: toDirection) => { | ||
| const scrollableContainer = document.querySelector(".InnerPage__container"); | ||
| if (scrollableContainer) { | ||
| const scrollToOptions: ScrollToOptions = { | ||
| behavior: "smooth", | ||
| }; | ||
|
|
||
| if (direction === "top") { | ||
| scrollToOptions.top = 0; | ||
| } else if (direction === "bottom") { | ||
| scrollToOptions.top = scrollableContainer.scrollHeight; | ||
| } | ||
|
|
||
| scrollableContainer.scrollTo(scrollToOptions); | ||
| } | ||
| }; |
There was a problem hiding this comment.
If possible, we shouldn't use DOM elements manually (document.querySelector). This might have some issues with React rendering. It's better to use useRef and scroll to the element we want to bring into the view.
Example of a hook that could handle it:
import { useEffect, useRef, useState } from "react";
export const useScrollIntoView = (
isEnabled: boolean,
scrollEl: React.MutableRefObject<HTMLDivElement | null>,
) => {
useEffect(() => {
if (isEnabled) {
scrollEl?.current?.scrollIntoView({ behavior: "smooth" });
}
}, [isEnabled, scrollEl]);
};Usage:
const scrollToEl = useRef<HTMLDivElement | null>(null);
// This can also be status from React Query
const [isScroll, setIsScroll] = useState(false);
useScrollIntoView(isScroll, scrollToEl);
|
I'll hold off on this PR while I work on the v3.0 release. Marking it as DRAFT for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Scroll to top when displaying a notification banner.
Why
Because it seems nothing happened, but there's actually a message at the top.
Address https://stellarorg.atlassian.net/browse/SDP-1415