Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 21.2.2 #1481

Closed
wants to merge 3 commits into from
Closed

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 24, 2024

What

Bump version to 21.2.2, creating release branch.

What is next

See the release instructions for a full rundown on the release process:
https://github.com/stellar/actions/blob/main/README-rust-release.md

Commit any changes to the release/v21.2.2 branch that are needed in this release.

If this is a regular release releasing from main, merge this PR when ready, and after merging, create a release for this version by going to this link: https://github.com/stellar/rs-soroban-env/releases/new?tag=v21.2.2&title=21.2.2

If this is a backport or patch release of a past version, see the release instructions. When ready to release this branch create a release by going to this link:
https://github.com/stellar/rs-soroban-env/releases/new?tag=v21.2.2&title=21.2.2&target=release/v21.2.2

@leighmcculloch leighmcculloch changed the title Bump version to v21.2.2 Bump version to 21.2.2 Oct 24, 2024
@leighmcculloch leighmcculloch marked this pull request as ready for review October 24, 2024 20:43
@leighmcculloch leighmcculloch requested a review from a team as a code owner October 24, 2024 20:43
@leighmcculloch leighmcculloch marked this pull request as draft October 24, 2024 20:44
#1477)

### What

Ported the implementation of binary search from Rust <=1.81 to Soroban
env.

### Why

This is necessary for 2 reasons:

- Fix the immediate issue of CI failing due to observation divergence in
Rust 1.82 caused by the binary search implementation change
- Protect ourselves from the similar issues in the future - we were
effectively observing the stdlib implementation and that's incorrect and
risky in the long term.

### Known limitations

N/A

(cherry picked from commit ee8afb3)
(cherry picked from commit 771e3e9)
@graydon graydon marked this pull request as ready for review October 24, 2024 21:41
@leighmcculloch
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants