Sign Transaction UI Test #1172
Merged
Sign Transaction UI Test #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
quietbits
approved these changes
Nov 22, 2024
| await expect(page.getByRole("listitem")).toHaveCount(6); | ||
|
|
||
| // Exit out of the wallet extension modal | ||
| await page.click("body", { position: { x: 10, y: 10 } }); |
There was a problem hiding this comment.
This test will break if the close button position changes, but style changes shouldn't affect the tests. We can't use a class selector? Something like page.locator(".wallets-header__button").
There was a problem hiding this comment.
it's more of a clicking outside of the modal
|
Preview is available here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign Transaction UI Test
For
LedgersandWallet Extension, it checks its happy path - making sure the dropdown works and trezor to open the new link. Ledger opens an extension so i skipped the new tab flow for ledger. Wallet Extension checks to make sure the modal pops up and it lists 6 wallets that it supports.