display 'transaction hash' component only if the xdr type is tx (#1132)

stellar · Nov 4, 2024 · e648d73 · e648d73
1 parent 5a28a76
commit e648d73
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/src/app/(sidebar)/xdr/view/page.tsx b/src/app/(sidebar)/xdr/view/page.tsx
@@ -71,7 +71,7 @@ export default function ViewXdr() {
     } catch (e) {
       return {
         jsonString: "",
-        error: `Unable to decode input as ${xdr.type}: ${e}`,
+        error: `Unable to decode input as ${xdr.type}: ${e}. Select another XDR type.`,
       };
     }
   };

diff --git a/src/components/TransactionHashReadOnlyField.tsx b/src/components/TransactionHashReadOnlyField.tsx
@@ -12,12 +12,18 @@ export const TransactionHashReadOnlyField = ({
     return null;
   }
 
+  const hashValue = transactionHashFromXdr(xdr, networkPassphrase);
+
+  if (!hashValue) {
+    return null;
+  }
+
   return (
     <Input
       id="tx-hash"
       fieldSize="md"
       label="Transaction hash"
-      value={transactionHashFromXdr(xdr, networkPassphrase)}
+      value={hashValue}
       copyButton={{ position: "right" }}
       disabled
     />

diff --git a/src/helpers/transactionHashFromXdr.ts b/src/helpers/transactionHashFromXdr.ts
@@ -3,4 +3,15 @@ import { TransactionBuilder } from "@stellar/stellar-sdk";
 export const transactionHashFromXdr = (
   xdr: string,
   networkPassphrase: string,
-) => TransactionBuilder.fromXDR(xdr, networkPassphrase).hash().toString("hex");
+) => {
+  try {
+    // Code to read XDR data
+    return TransactionBuilder?.fromXDR(xdr, networkPassphrase)
+      .hash()
+      .toString("hex");
+  } catch (e) {
+    // @TODO Do nothing for now
+    // add amplitude error tracking
+    return;
+  }
+};