Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI failures due to race condition in recoverysigner unit tests #5472

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Sep 23, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fix a race condition in unit tests that causes pq: role 'user_ro' already exists error. The error happens when another transaction creates the role at the same time. Handle this by ignoring the error if the role already exists. This is similar to what was done in #5398 for fixing CI failures in RecoverySigner unit tests.

Why

Fixes CI error seen in RecoverySigner unit tests

Known limitations

N/A

@urvisavla urvisavla marked this pull request as ready for review September 24, 2024 07:14
@urvisavla urvisavla merged commit 6fbba33 into stellar:master Sep 24, 2024
23 checks passed
@urvisavla urvisavla deleted the fix-ci-failures branch September 24, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants