Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to horizon docker builds #5466

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

mwtzzz
Copy link
Contributor

@mwtzzz mwtzzz commented Sep 19, 2024

What

  • a new Dockerfile to install Core from the "testing" pool an update to the Makefile specifically for this case
  • a new Dockerfile to install Core and Horizon from their "stable" pools
  • additional comments to clarify what the different files do

Why

this is needed to support Horizon's new workflow

Testing

this has been tested successfully

Issue addressed by this PR

https://github.com/stellar/ops/issues/3124

### What
a new Dockerfile to install Core from the "testing" pool
an update to the Makefile specifically for this case

### Why
adding support for the "testing" pool to the Dockerfile would make
the file more confusing to read, so I decided to use a separate Dockerfile

### Testing
I will test this manually shortly

### Issue addressed by this PR
stellar/ops#3124
@mwtzzz mwtzzz marked this pull request as ready for review September 19, 2024 01:07
mwtzzz and others added 2 commits September 24, 2024 12:07
### What
build horizon docker image from core "stable" and horizon "stable"

### Why
this is needed in order to support the new workflow described in the
ticket

### Testing
this has been tested and works with apt "testing"

### Issue addressed by this PR
stellar/ops#3124
@mwtzzz mwtzzz changed the title allow for the bundling of Core package from apt "testing" pool updates to horizon docker builds Sep 24, 2024
@mollykarcher mollykarcher merged commit 9e0c2c0 into stellar:master Sep 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants