Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: migrate to docker compose v2 #5409

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Aug 2, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Migrate to Docker Compose v2, which requires changing the docker compose invocation from docker-compose to docker compose.

The exec.Command in Go doesn’t support commands with spaces in them, so passing compose as a separate argument to the docker command.

Why

GitHub Ubuntu runners for CI removed support for Docker Compose v1, causing our CI to fail.

Known limitations

@urvisavla urvisavla marked this pull request as ready for review August 2, 2024 22:44
@urvisavla urvisavla merged commit 81dbb68 into stellar:master Aug 3, 2024
23 checks passed
@urvisavla urvisavla deleted the fix-ci-docker-compose branch August 3, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants