Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/ingest: historyRange and reingestHistoryRange states send batches of ledgers to tx processors #5117

Merged
merged 12 commits into from
Nov 28, 2023

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Nov 15, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Changed the historyRange and reingestHistoryRange state machines to send batches of ledgers to tx processors to be processed into memory and then flushed to current db tx once.

For context, the pre-req of tx processors enablement with fast batch builders for holding multiple ledger updates in memory and then flushing once was merged in #4909, this changeset builds upon that by now letting these ranged state machine ingestions to pass a range of ledgers to the tx processors.

The batch size of ledgers is configurable per Config.MaxLedgerPerFlush

Why

Ingestion performance, reducing the number of db round trips for tx commits to lower overall time to finish ingestion range.
Closes #5099

Known limitations

this batching of ledgers for db round trips was only applicable to the two reingest states historyRange and reingestHistoryRange

@sreuland sreuland marked this pull request as draft November 15, 2023 23:29
@sreuland sreuland marked this pull request as ready for review November 17, 2023 16:53
services/horizon/cmd/db.go Outdated Show resolved Hide resolved
services/horizon/cmd/db.go Outdated Show resolved Hide resolved
@tamirms
Copy link
Contributor

tamirms commented Nov 27, 2023

@sreuland this PR looks good! The 2 bugs mentioned at the end of #5099 are not addressed in this PR. Is the plan to spin out separate issues for those 2 bugs?

@sreuland
Copy link
Contributor Author

@sreuland this PR looks good! The 2 bugs mentioned at the end of #5099 are not addressed in this PR. Is the plan to spin out separate issues for those 2 bugs?

@tamirms, yes, have created #5128 and #5127

@sreuland sreuland merged commit eb5054f into stellar:master Nov 28, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest batches of ledgers in-memory before flushing to DB
3 participants