Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest/processors: Refactor participants processors to support new ingestion data flow #5024

Merged

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Aug 22, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Similar to #5004 , this PR refactors the ParticipantsProcessor so it conforms to the following interface:

type horizonTransactionProcessor interface {
	ProcessTransaction(xdr.LedgerCloseMeta, ingest.LedgerTransaction) error
	Commit(ctx context.Context, session db.SessionInterface) error
}

This PR also makes use of the loaders implemented in #5019 because the history participants tables have integer column ids which refer to rows in the history_accounts table.

Why

#4909

Known limitations

Several tests are failing because the ingestion framework still needs to be updated to support the new interface. All those tests will be fixed after all the processors have been migrated to the new data flow.

@tamirms tamirms requested a review from a team August 22, 2023 13:50
}
}

type participant struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, the new Builder and Loaders decluttered the processor quite a bit!

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is coming along so well, wow 👏 and the future-loader model fits like a glove

services/horizon/internal/db2/history/participants_test.go Outdated Show resolved Hide resolved
@tamirms tamirms merged commit 461e5a1 into stellar:ingestion-next Aug 23, 2023
1 of 14 checks passed
@tamirms tamirms deleted the refactor-participants-processor branch August 23, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants