all: yet another Soroban XDR bump #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
bump-xdr-again
branch
from
adbe310
to
498d556
Compare
5 tasks
|
Soroban-rpc has been bumped with the changes at stellar/stellar-cli#846 However, a (puzzling) |
2opremio
force-pushed
the
bump-xdr-again
branch
from
23d439a
to
9fdd899
Compare
|
It seems to work if we ensure soroban-rpc is one ledger ahead of horizon when computing preflights. It doesn't work if we only ensure that soroban-rpc's latest ledger is equal or greater than Horizon's, which is puzzling. |
|
This was the cause of the problem state above stellar/stellar-cli@dcb79ce |
Shaptic
reviewed
Aug 8, 2023
sreuland
reviewed
Aug 8, 2023
sreuland
approved these changes
Aug 8, 2023
tamirms
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ec04dce3983103f8ed8b3b25ef028c08c9d8c59d
Fixes part of stellar/stellar-cli#844
Integration tests won't pass until I update soroban-rpc and push a container with the update.