services/horizon add horizon binary building Makefile #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
reviewed
Jul 27, 2023
sreuland
approved these changes
Aug 4, 2023
urvisavla
reviewed
Aug 4, 2023
### What This PR adds Makefile entries to allow us to build horizon in an isolated, docker based, environment. ### Why This will make build process more transparent and it will simplify build systems where horizon is built.
This commit improves the way we handle non-amd64 architectures. Build command should work on all architectures that the debian image supports. In case of an unsupported architecture build will error letting user know clearly that it failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds Makefile entries to allow us to build horizon in an isolated, docker based, environment.
Why
This will make build process more transparent and it will simplify build systems where horizon is built.