-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Internal Horizon Documentation #4948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya1702
changed the title
Revamp internal Horizon documentation
Revamp Internal Horizon Documentation
Jul 7, 2023
sreuland
reviewed
Jul 10, 2023
sreuland
reviewed
Jul 10, 2023
sreuland
reviewed
Jul 10, 2023
sreuland
reviewed
Jul 10, 2023
sreuland
reviewed
Jul 10, 2023
sreuland
reviewed
Jul 10, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
sreuland
reviewed
Jul 11, 2023
urvisavla
reviewed
Aug 2, 2023
urvisavla
reviewed
Aug 2, 2023
urvisavla
reviewed
Aug 2, 2023
urvisavla
reviewed
Aug 2, 2023
urvisavla
reviewed
Aug 2, 2023
urvisavla
reviewed
Aug 2, 2023
urvisavla
reviewed
Aug 3, 2023
urvisavla
reviewed
Aug 3, 2023
urvisavla
reviewed
Aug 3, 2023
urvisavla
reviewed
Aug 3, 2023
sreuland
reviewed
Aug 4, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
reviewed
Aug 7, 2023
sreuland
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new consolidated content looks good, thanks for addressing all the feedback, I left a few additional suggestions on minor tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Closes #4936 and #4939
This PR rearranges and adds internal documentation:
Why
There was a lot of redundant readme files and documentation that made it harder for someone new in the team to understand the codebase. These changes remove the duplicate documentation, adds some new READMEs and brings all important resources under a single roof.
Known limitations
None.