Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANCHOR-809][SEP-6] Add funding_method to SEP-6 #1582

Merged
merged 8 commits into from
Dec 2, 2024
Merged

[ANCHOR-809][SEP-6] Add funding_method to SEP-6 #1582

merged 8 commits into from
Dec 2, 2024

Conversation

JiahuiWho
Copy link
Contributor

Description

  • In /info response, replace fields(in deposit) and types(in withdraw) with funding_methods
  • In all 4 transaction creation request, replace type with funding_method, and this param will be mandatory

Context

SEP-31 changes scoped in stellar/stellar-protocol#1567

Testing

  • ./gradlew test

@JiahuiWho JiahuiWho marked this pull request as ready for review November 26, 2024 19:00
@JiahuiWho JiahuiWho merged commit e67e65a into stellar:develop Dec 2, 2024
8 checks passed
@JiahuiWho JiahuiWho deleted the anchor-809-6 branch December 2, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijamie98 lijamie98 lijamie98 left review comments

@philipliu philipliu philipliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiahuiWho @lijamie98 @philipliu