[CHORE] Merge develop into feature/v3
#1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description All fields are configurable by the `config` struct in the value file. Previously, only the callback API was configurable using this method. ### Context We need to be able to configure using a separate Horizon instance. Rather than hardcoding the value mapping like the callback API, this refactors how config management is done. ### Testing - `./gradlew test` - Testing with the demo wallet ### Documentation N/A ### Known limitations This is a breaking change so the deployed environments will need to be updated.
…ep10.home_domain` and `sep10.home_domains` (#1347) ### Description The error message is confusing because the actual limitation is 59 bytes. ``` The sep10.home_domain (%s) is longer than the maximum length (64) of a domain. Error=%s ``` ### Context Bug fix. ### Testing - `./gradlew test` ### Documentation N/A ### Known limitations N/A
### Description A previous commit refactored the config map by moving `horizonEndpoint` into the values file but did not set the associated environment variable. ### Context The reference server is crashing in dev. ### Testing - `./gradlew test` - Tested with demo wallet. ### Documentation N/A ### Known limitations N/A
### Description - Updated workflow file for running code scanning through CodeQL on pull requests and pushes to develop branch. ### Context - CodeQL scanning wasn't working correctly
### Description This allows pod-level annotations to be set. ### Context We need to tell which port and endpoint Prometheus should scrape the metrics from using annotations. ### Testing - `./gradlew test` - Verified the manifest is correctly generated using `helm template` ### Documentation N/A ### Known limitations N/A
### Description This adds the `metric.prefix` configuration. When set, all metrics will be prefixed with the specified prefix value. ### Context We need to prefix all metrics with `ap` for Prometheus. ### Testing - `./gradlew test` - Checked the metrics have the specified endpoint when set, and nothing when not set. ### Documentation N/A ### Known limitations N/A
### Description Improve error message on Horizon errors ### Context Current error message simply says `Error response from the server` without any explanation ### Testing - `./gradlew test` ### Documentation N/A ### Known limitations N/A
### Description Add support for withdrawals for existing `notify_refund_pending` RPC method ### Context I noticed refunds are not available for `pending_user_transfer_complete` and `pending_external statuses`. Generally speaking, in the regular flow transaction goes from `pending_user_transfer_start` -> `pending_anchor` -> `completed` However, when the anchor takes times to process a transaction and it's still in `pending_anchor` , user wants to refund it and can do so. In the cases where status is `pending_user_transfer_complete` (funds are available for pickup) or `pending_external` (funds are processed by external entity) we want to fist move it to `pending_anchor` to indicate that funds are not available for pickup anymore, (or that bank transfer was cancelled), i.e. indicate that refund has been initiated. In this case, if we have issues with Stellar transfer or Circle, etc. transaction won't be in status that shows user wrong information. (Especially in `pending_user_transfer_complete` case, where user funds is technically no longer available for pickup anymore, but status doesn't show that) After that, we can use existing `notify_refund_send` RPC. ### Testing - `./gradlew test` - Added new test cases ### Documentation Flow charts should be updated (https://stellarorg.atlassian.net/browse/ANCHOR-688) ### Known limitations N/A
### Description Add Futurenet in Network config ### Context Previously, Futurenet was not supported ### Testing - `./gradlew test` ### Documentation N/A ### Known limitations N/A
### Description Reduce log level of PaymentObservingAccountsManager to DEBUG ### Context Current log level is INFO, and it prints debugging information ### Testing N/A ### Documentation N/A ### Known limitations N/A
### Description Fix bug when exception was thrown on null platformSecret for callback/custody secret encoding ### Context Wrong secret was checked for being null ### Testing - /gradlew test - Changed existing test to reproduce ### Documentation N/A ### Known limitations N/A
### Description - Deprecate `signing_key` and `domain`, replace with `signing_keys` and `domains` - Remove `signing_key` field for noncustodial client (usage only found in validation) - Replace the use of `signing_key` and `domain` with `signing_keys` and `domains` in related function and test cases ### Testing - `./gradlew test` ### Documentation Will update in https://developers.stellar.org/network/anchor-platform/admin-guide/sep10
### Description Bumps the version numbers to 2.7.0. ### Context 2.7.0 release ### Testing - `./gradlew test`
### Description Update README to access the workflow test results ### Context Improve the documentation. ### Testing - `./gradlew test` ### Documentation N/A ### Known limitations N/A
### Description Disable the Junit concurrency for test stability reason. ### Context The tests had been unstable due to the concurrency that fails some of the tests. ### Testing - `./gradlew test` - The workflow is successful for 5 consecutive runs. ### Documentation NA. ### Known limitations NA.
…1366) ### Description This PR add check to `ObservingAccountsBeans ` to check if SEP-31 is enabled. In this case the bean is always created, but only activate if SEP-31 is enabled. This is because this bean is required in the presence for the creation of `PaymentObserverBeans`. We can't simply use conditional annotation that disable the bean's creation ### Context The PaymentObseringAccountManager should only be restarted when needed. Currently only SEP-31 requires the service. ### Testing - `./gradlew test`
### Description - Add new field `user_action_required_by` to SEP-6/24/31 transactions and related DB entries. - Added configuration option for SEP-6 and SEP-24 to set initial value on transaction creation. - Added support for related RPC requests to update this field. - Added ability to query platform transactions sorted by `user_action_required_by` field ### Context Implements stellar/stellar-protocol#1484 ### Testing - `./gradlew test` - New test cases covering all new features ### Documentation https://stellarorg.atlassian.net/browse/ANCHOR-688 https://stellarorg.atlassian.net/browse/ANCHOR-704 ### Known limitations N/A
### Description - TODO: describe what this change does ### Context - TODO: describe why this change was made ### Testing - `./gradlew test` - TODO: replace with any additional test steps ### Documentation TODO: If this pull request adds a feature, describe changes to documentation that has been made - Attach stellar-docs pull request, documenting new feature - If it's an urgent feature request, please create a ticket and attach ticket number to this PR ### Known limitations TODO: describe any limitations or replace with N/A
### Description - TODO: describe what this change does ### Context - TODO: describe why this change was made ### Testing - `./gradlew test` - TODO: replace with any additional test steps ### Documentation TODO: If this pull request adds a feature, describe changes to documentation that has been made - Attach stellar-docs pull request, documenting new feature - If it's an urgent feature request, please create a ticket and attach ticket number to this PR ### Known limitations TODO: describe any limitations or replace with N/A
### Description - Upgrade JDK from 11 to 17. - Fix Jwt Json serialization ### Context - JDK 11 is expected to sunset in 10/2024. ### Testing - `./gradlew test` ### Documentation Update `How to Contribute` doc. ### Known limitations N/A
…ssets (#1369) ### Description - Fix trailing comma in assets JSON file causes a "null" assets Although the trailing comma in JSON does not cause gson parsing failure, it creates a `null` entry in the result `Assets` object. The PR removes the `null` entry. ### Context - Bug fixe. ### Testing - `./gradlew test` ### Documentation N/A ### Known limitations N/A
### Description As title ### Context id_type is part of refunds' payments object schema However, it’s missing in JdbcSep24RefundPayment object ### Testing - `./gradlew test ### Known limitations Right now SEP6/24/31 are using different pattern for refund payment and that should be unified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ANCNHOR-626] Update ClientsConfig with SigningKeys and Domains introduced change to ClientsConfig,
merge develop to bring feature/v3 up to date
Context
Merge
developintofeature/v3Testing
./gradlew test