Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANCHOR-346] Fix trailing comma in assets JSON file causes a "null" assets #1369

Merged
merged 5 commits into from
May 28, 2024
Merged

[ANCHOR-346] Fix trailing comma in assets JSON file causes a "null" assets #1369

merged 5 commits into from
May 28, 2024

Conversation

lijamie98
Copy link
Collaborator

@lijamie98 lijamie98 commented May 17, 2024 •
edited
Loading

Description

  • Fix trailing comma in assets JSON file causes a "null" assets

Although the trailing comma in JSON does not cause gson parsing failure, it creates a null entry in the result Assets object. The PR removes the null entry.

Context

  • Bug fixe.

Testing

  • ./gradlew test

Documentation

N/A

Known limitations

N/A

@lijamie98 lijamie98 marked this pull request as draft May 17, 2024 16:04
@lijamie98 lijamie98 marked this pull request as ready for review May 28, 2024 16:27
@lijamie98 lijamie98 changed the title [ANCHOR-346] Feature/anchor 346 trailing comma in assets json [ANCHOR-346] Fix trailing comma in assets JSON file causes a "null" assets May 28, 2024
@lijamie98 lijamie98 requested a review from philipliu May 28, 2024 16:30
@lijamie98 lijamie98 merged commit 652c680 into stellar:develop May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiahuiWho JiahuiWho JiahuiWho approved these changes

@philipliu philipliu Awaiting requested review from philipliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijamie98 @JiahuiWho