Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-534] Concurrent Github Workflows #1196

Merged

Conversation

lijamie98
Copy link
Collaborator

@lijamie98 lijamie98 commented Nov 8, 2023

Description

Created the following workflows:

  • on_pull_request.yml: triggered when a pull request is created or updated
  • on_pull_request_comments.yml: triggered callable workflows when a pull request is commented
  • on_push_to_develop.yml: triggered when a pull request is merged or a commit is pushed.
  • on_release_created_or_updated.yml: triggered when a release is created or updated.

Here are the callable workflows:

  • sub_gradle_build.yml: Run Gradle build and unit tests.
  • sub_essential_tests.yml: Run essential tests.
  • sub_extended_tests.yml: Run extended tests.
  • sub_codeql_analysis.yml: Run the CodeQL.
  • sub_jacoco_report.yml: Generate the Jacoco reports.

Context

Improve the workflows

Testing

  • ./gradlew test

Known limitations

  • Duplicated tests are to be merged
  • Some disabled tests are to be re-enabled in future PRs.

@lijamie98 lijamie98 marked this pull request as draft November 8, 2023 22:07
@lijamie98 lijamie98 force-pushed the feature/anchor-534-concurrent-workflows branch 29 times, most recently from 090b2da to f68cbec Compare November 9, 2023 04:29
@lijamie98 lijamie98 force-pushed the feature/anchor-534-concurrent-workflows branch 17 times, most recently from b597918 to e01e72d Compare November 10, 2023 01:32
@lijamie98 lijamie98 force-pushed the feature/anchor-534-concurrent-workflows branch from e01e72d to 56efd16 Compare November 10, 2023 01:55
@lijamie98 lijamie98 marked this pull request as ready for review November 10, 2023 02:08

jobs:
run-extended-tests:
if: github.event.issue.pull_request && contains(github.event.comment.body, '/run-extended-tests')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how does this issue works? Does it mean that every comment will trigger the workflow re-run?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the work flow will be checked but nothing will be run.

Copy link
Contributor

@JiahuiWho JiahuiWho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lijamie98 lijamie98 merged commit 97add17 into stellar:develop Nov 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants